-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite of current esx_policejob #60
Open
Zykem
wants to merge
21
commits into
esx-framework:dev
Choose a base branch
from
Zykem:rewrite/policejob
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated locales and removed the unused ones + lazy load
706d0a1
to
6fe39b0
Compare
…cejob into rewrite/policejob
Added locale files for translators (currently all in english)
Code improvements (avoiding useless GetPlayerFromId function call, re-using targetPlayer state instead)
…cejob into rewrite/policejob
This feature allows to add/remove weapons for specific grades. (Grades that can do this are configurable under Config.ArmoryManagementGrades)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic of the server-sided event
esx_policejob:impoundVehicle
located in server/vehicleActions.lua expectsthe esx_garage script the
MissionRowPD
garage to exist. (in order to put the owner's vehicle back to a garage)Since i am not sure if esx_garage will handle it, i will just provide the esx_garage "Garage Object" here for someone to create a PR?